----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114999/#review47390 -----------------------------------------------------------
like with the other patch I'm not sure whether that's a good idea as that breaks any communication with the kdelibs4. - Martin Gräßlin On Jan. 14, 2014, 4:21 p.m., Jonathan Riddell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114999/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2014, 4:21 p.m.) > > > Review request for KDE Runtime, David Faure and Martin Klapetek. > > > Repository: kglobalaccel > > > Description > ------- > > Rename the dbus interfaces from > org.kde.kglobalaccel.Component to org.kde.kf5kglobalaccel.Component > > and > org.kde.kglobalaccel to org.kde.kf5kglobalaccel > > this prevents files overlapping with equivalents in kdelibs4 and prevents an > overlap of the dbus interface > > > Diffs > ----- > > src/CMakeLists.txt d48e92e > src/kglobalaccel.h d11881c > src/kglobalaccel.cpp 54d18ec > src/kglobalaccel_p.h b1528dc > src/kglobalshortcutinfo.h 7f0e18a > src/org.kde.KF5KGlobalAccel.xml PRE-CREATION > src/org.kde.KGlobalAccel.xml 8746551 > src/org.kde.kf5kglobalaccel.Component.xml PRE-CREATION > src/org.kde.kglobalaccel.Component.xml ec21201 > > Diff: https://git.reviewboard.kde.org/r/114999/diff/ > > > Testing > ------- > > > Thanks, > > Jonathan Riddell > >