Code Review of baloo/file/lib ==file.cpp
Should it override type() from Item and set it to "File" ? ==filemodifyjob.cpp. The code won't unset a rating, comments or tags on multiple files. You update Xapian ok, but you're not calling fsetxattr(). The d pointer leaks? ==DB.cpp SQLITE3-> SQLITE ==general Are you planning on putting all the Xapian queries in a new thread in the future? If not having a KJob API doesn't have any benefit does it? I would suggest you namespace your header guards i.e #ifndef FILE_H -> #ifndef BALOO_FILE_H The current ones are very generic, it will be very easy to accidentally clash. David David