----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115079/#review47868 -----------------------------------------------------------
I guess it's obvious from the matching review request for kgloballacel: I consider copying the files to every user as the wrong solution. In Qt terms I would give it a -2. - Martin Gräßlin On Jan. 21, 2014, 1:48 p.m., Jonathan Riddell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115079/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2014, 1:48 p.m.) > > > Review request for kde-workspace and Martin Gräßlin. > > > Repository: kde-workspace > > > Description > ------- > > to go with https://git.reviewboard.kde.org/r/115078/ use local dbus interface > files > > > Diffs > ----- > > kcontrol/keys/org.kde.kglobalaccel.Component.xml PRE-CREATION > kcontrol/keys/org.kde.KGlobalAccel.xml PRE-CREATION > kcontrol/keys/CMakeLists.txt 072e614 > > Diff: https://git.reviewboard.kde.org/r/115079/diff/ > > > Testing > ------- > > > Thanks, > > Jonathan Riddell > >
