-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115250/
-----------------------------------------------------------
Review request for kdelibs and David Faure.
Repository: kdelibs
Description
-------
FTP has two modes: PASV and EPSV.
Not all server's support EPSV.
Currently, kio_ftp gives up on PASV mode if socks proxy is enabled.
That is because QHostAddress.protocol() returns -1 (unknown protocol) on
KUrl("socks://localhost:3128").
So kio_ftp fails using SOCKS proxy on server's that lack EPSV support.
This patch makes sure kio_ftp will try PASV mode if socks proxy is enabled.
Diffs
-----
kioslave/ftp/ftp.cpp 5bb2e8d
Diff: https://git.reviewboard.kde.org/r/115250/diff/
Testing
-------
Tested a server that lacks EPSV support with and without proxy.
Seems fine now.
Used to throw 'Internal Server error'.
Thanks,
Emil Sedgh
