----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114567/#review48097 -----------------------------------------------------------
ksmserver/screenlocker/ksldapp.h <https://git.reviewboard.kde.org/r/114567/#comment34041> Note that this is a "boolean trap"[1], also the argument for "secondary" should imho be the second argument. http://ariya.ofilabs.com/2011/08/hall-of-api-shame-boolean-trap.html - Martin Klapetek On Jan. 23, 2014, 12:17 a.m., James Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114567/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2014, 12:17 a.m.) > > > Review request for kde-workspace and Aaron J. Seigo. > > > Repository: kde-workspace > > > Description > ------- > > Adds a second screen locking keyboard combination to provide advanced > selective lock signaling to running applications for such things as pausing > MPRIS2 players in Kmix to setting away status in Telepathy. Applications are > connected differently from standard screen saver signaling which is decidedly > a blunt handled instrument. > > A SecondaryActiveChanged signal for freedesktop.org in addition to > ActiveChanged would be great to have moved into freedesktop.org with the > above goal and cross-desktop in mind. Right now the implementation sits > happily in org.kde.screensaver. > > > Diffs > ----- > > ksmserver/screenlocker/ksldapp.h b292b62 > ksmserver/screenlocker/ksldapp.cpp 7c2d63f > ksmserver/screenlocker/interface.cpp e3579fb > ksmserver/screenlocker/interface.h 97a6073 > ksmserver/screenlocker/dbus/org.kde.screensaver.xml e700b88 > > Diff: https://git.reviewboard.kde.org/r/114567/diff/ > > > Testing > ------- > > Compile, run. > > > Thanks, > > James Smith > >
