----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115260/#review48193 -----------------------------------------------------------
Ship it! Looking good. Some niggles, and it's good to go in. plasma/desktop/qmlpackages/lookandfeel/contents/osd/Osd.qml <https://git.reviewboard.kde.org/r/115260/#comment34086> I think currently, the timeout is 2500, that seems enough for me. plasma/desktop/qmlpackages/lookandfeel/contents/osd/Osd.qml <https://git.reviewboard.kde.org/r/115260/#comment34087> ; at the end in scripts - Sebastian Kügler On Jan. 24, 2014, 11:42 a.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115260/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2014, 11:42 a.m.) > > > Review request for kde-workspace and Plasma. > > > Repository: kde-workspace > > > Description > ------- > > Adds the default OSD look&feel file to the default package. > > The OSD features just an icon and (a progress bar OR a text). It uses > standard Plasma components for drawing things, Marco has on his todo list to > turn the progress bar black, will look better when that's done. > > When the OSD is showing progress, no text is shown (can be overriden by the > look&feel package). > > > Diffs > ----- > > plasma/desktop/qmlpackages/lookandfeel/contents/osd/Osd.qml PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/115260/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > screenshot with default theme > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/23/a864bc46-27b8-411b-9362-03c1fb6a3bbc__osd.png > > > Thanks, > > Martin Klapetek > >
