----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115311/#review48254 -----------------------------------------------------------
Looks fine (and required) - thanks. In case you do not have commit rights (nor do intend to ask for), please upload a "git format-patch" variant (to maintain the commit metadata, namely your identity) For potential future patches (welcome ;-) please set the group to "kwin", the KWin maintainer is "graesslin". - Thomas Lübking On Jan. 25, 2014, 1:57 a.m., James Jones wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115311/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2014, 1:57 a.m.) > > > Review request for kde-workspace, Thomas Lübking and Marco Martin. > > > Repository: kde-workspace > > > Description > ------- > > [kwin] Don't call into GL without a context > > After losing current from the EGL or GLX > context, calls to the GL or GLES functions > have undefined behavior. Perform all > cleanup that may touch OpenGL and check for > GL errors before losing current from the > context. > > > Diffs > ----- > > kwin/egl_wayland_backend.cpp b229cdd84161a64d5cd93c189514067867773e7f > kwin/eglonxbackend.cpp dd41da55b94821802f2d1464794db39bd636088a > kwin/glxbackend.cpp 73f463e9df43c2cd71836ce3f48da84fb4df35ed > kwin/scene_opengl.cpp 961e81fbcc39940bc49179899e034ad8a9e802cd > > Diff: https://git.reviewboard.kde.org/r/115311/diff/ > > > Testing > ------- > > Compiled/Installed kde-workspace on x86 > kwin_gles (EGL+X11) - Tested mode switching > kwin (GLX) - Tested mode switching > > > Thanks, > > James Jones > >