> On Jan. 30, 2014, 9:20 p.m., Thomas Lübking wrote: > > tried to center align it? > > kdeuser56 kdeuser56 wrote: > Center what? The widget or the iconlabel? I think in case of the widget > it makes no sense. > In case of the iconlabel the icon itself would be on the exact same > position as the icon of the icon button. > I tried both, but I find right aligned prettier and more logical > considering the text under it. > > Thomas Lübking wrote: > Either. Reason is that due to the "arbitrary" shape (shadow, padding), > rightaligning the icon/button does not really line up with the text - thus > looks buggy (failed approach) > > Otoh, left alingning looks unbalanced mostly due to the vertical tab > border (ie. it's less an issue in eg. bespin, which has no vertical tabborder) > > kdeuser56 kdeuser56 wrote: > I am not sure I understand your point. Could explain me the "arbitrary" > shape problem? > I do not think the visual problem is caused by the vertical tab border. > Even if I remove that, it still looks bad and the bigger the font gets, the > uglier it looks. (Some words are longer in other languages, so this could > also be triggered by different language settings). > So in my opinion it looks bad, regardless of the theme. > Do you have another idea? > > > kdeuser56 kdeuser56 wrote: > I would be okay with centering the iconlabel. Centering the widget too > would be still better than left aligning, but I would prefer to keep it > right. > Should I change the diff to center the iconlabel, or should I provide > screenshots first? > > Thomas Lübking wrote: > > Could explain me the "arbitrary" shape problem? > The icons do not have a defined border as the text. They'll visually end > some pixels before the logical end (would even get worse for icons that do > not contain a sheet, but even that is visually 2px off) > > "Ugly" is subjective. > Fact is, that the vertical border creates a distinct border that the left > aligned version is closer to than to the implicit right border, thus it's > unbalanced (left overweight) > If you remove that border, the label visually moves more to the center > between window frame and implicit right border (the lineedit), what implies > local symmetry, thus stability. (Actually, you might even get a golden mean > positioning) > Granted: for long texts and huge fonts the part left of the tab certainly > becomes neglectable and that effect is lost. > -> I'd simply center align the icon.
I'd suggest to have screenshots and wait for some more opinions then. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115408/#review48658 ----------------------------------------------------------- On Jan. 30, 2014, 9:07 p.m., kdeuser56 kdeuser56 wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115408/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2014, 9:07 p.m.) > > > Review request for kdelibs. > > > Repository: kdelibs > > > Description > ------- > > The iconbutton and the iconlabel were clearly aligned using the old style, > when everything was left aligned. > In my interpretation of the KDE HIG guidelines, the iconbutton/label should > also be right aligned. > Especially with bigger font sizes, the visual issue becomes obvious. > > Idea: see kproperties-dolphin-1.png > Before: see before-1.png and before-2.png > After: see after-1.png and after-2.png > > Diff for kio (frameworks) can be found here: http://pastebin.kde.org/p4ojv6a1w > > > Diffs > ----- > > kio/kfile/kpropertiesdialog.cpp 6611ee7 > > Diff: https://git.reviewboard.kde.org/r/115408/diff/ > > > Testing > ------- > > Compiled and installed. Works as expected. > > > File Attachments > ---------------- > > idea > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/91648ead-a248-4c42-b45c-8741d1291955__kproperties-dolphin-1.png > before1 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/f9b5bba2-f810-4de5-b292-da66e0cf60ac__before-1.png > before2 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/516dbfec-597f-4f95-bb83-797d10ddebfc__before-2.png > after1 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/03fdb43f-6f67-407f-be27-e6afad906340__after-1.png > after2 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/01/30/06455bef-a229-4a1a-b9c0-cb1de61f7fa0__after-2.png > > > Thanks, > > kdeuser56 kdeuser56 > >
