----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115183/#review49356 -----------------------------------------------------------
Jonathan, I think Plasma developers have no time to look at this patch, they are busy with Plasma Next. If there are no objections in the next 7 days, please commit it to 4.11 branch. I do not understand the bug fully, but I am using the patch since a few weeks, and did not notice a regression (not that I am a heavy krunner user). - Christoph Feck On Jan. 21, 2014, 4:23 p.m., Jonathan Marten wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115183/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2014, 4:23 p.m.) > > > Review request for kde-workspace. > > > Bugs: 314690 > http://bugs.kde.org/show_bug.cgi?id=314690 > > > Repository: kde-workspace > > > Description > ------- > > The referenced bug describes a recent change in the KRunner command history > which makes recalling previous commands confusing, and different to the way > that history recall works in Bash and other shells. I don't know whether > this change was deliberate or accidental, but in the interests of consistency > this patch ensures that the command history is reset to the beginning when > showing the runner. > > > Diffs > ----- > > krunner/interfaces/default/interface.cpp 505e0aa > > Diff: https://git.reviewboard.kde.org/r/115183/diff/ > > > Testing > ------- > > Built kde-workspace with this change, verified operation of runner history. > Also verified by another bug reporter. > > > Thanks, > > Jonathan Marten > >
