> On March 26, 2014, 12:27 p.m., Dawit Alemayehu wrote:
> > Do you want me to apply this patch with the minor changes I suggested?
Sorry for the late reply!
Based on how these metadata are used (ssl_in_use, ssl_was_in_use) if the map
contains the key the associated value string could (well... should) only be
equals to "TRUE" or "FALSE". So when looking up for the key using
queryMetaData() if the map doesn't contain the key a Null string is returned,
that's why i used !sslInUse.isNull() (it's the same as checking for
map.contains(key)).
About the other changes you suggested i found my code more readable.
However the goal doesn't change so i'm fine if you apply the patch with the
changes you suggested.
One last thing i found grepping the code for "ssl_in_use".
In kdelibs/kio/kio/accessmanager.cpp:482 should not the check
if (metadata.contains(QL1S(""ssl_in_use"")))
be changed to
if (metadata.value(QL1S("ssl_in_use")) == QL1S("TRUE"))
for the same reason i stated above?
- Andrea
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116602/#review54178
-----------------------------------------------------------
On March 4, 2014, 9:43 p.m., Andrea Iacovitti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116602/
> -----------------------------------------------------------
>
> (Updated March 4, 2014, 9:43 p.m.)
>
>
> Review request for kdelibs and Dawit Alemayehu.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> If incomingMetaData doesn't contain item with key "ssl_in_use" (and i
> verified this happen) using [] operator results in inserting a new item with
> key "ssl_in_use" and NullString value in incomingMetaData map and, as a
> consequence, a new item with key "ssl_was_in_use" and NullString value in
> outgoingMetaData map.
> This patch aims to avoid this situation by looking up the key using
> queryMetadata().
>
>
> Diffs
> -----
>
> kio/kio/job.cpp edc5fed
>
> Diff: https://git.reviewboard.kde.org/r/116602/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrea Iacovitti
>
>
