----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117174/ -----------------------------------------------------------
Review request for kdelibs, Albert Astals Cid, Aaron J. Seigo, David Faure, and Ian Monroe. Bugs: 149479 http://bugs.kde.org/show_bug.cgi?id=149479 Repository: kdelibs Description ------- Even though the bug appears RESOLVED it is not. Minor hack to packagestructure.cpp to search for the metadata.desktop file recursively. This helps with installing desktop themes and removing them. I have tested this on kdelibs 4.13 compiled with kdesrc-build. When testing themes ignore SoftSand for example, it's metadata.desktop is not properly formatted. There are others too which are not formatted which I guess could be fixed by setting a new format standard, maybe even a check package script to check new uploads on kde-look.org. Diffs ----- plasma/packagestructure.cpp 71148e1 Diff: https://git.reviewboard.kde.org/r/117174/diff/ Testing ------- Compiled, run systemsettings, go to Desktop Themes, install / remove away. Some themes are broken so they won't work (not install). Thanks, Andrei Amuraritei