----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117175/#review54584 -----------------------------------------------------------
Hi, there is an error when trying to show the patch on reviewboard. Can you provide the correct patch? I looked into the raw patch and I think the "return 1" line that you commented should be kept when the action is not upgrade. - Lamarque Souza On March 30, 2014, 3:47 a.m., Andrei Amuraritei wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117175/ > ----------------------------------------------------------- > > (Updated March 30, 2014, 3:47 a.m.) > > > Review request for KDE Runtime, Albert Astals Cid, Aaron J. Seigo, Ian > Monroe, and Lamarque Souza. > > > Bugs: 306279 and 325028 > http://bugs.kde.org/show_bug.cgi?id=306279 > http://bugs.kde.org/show_bug.cgi?id=325028 > > > Repository: kde-runtime > > > Description > ------- > > When installing a new .comic provider from GHNS, it doesn't appear in the > installed list on the comic widget. > This fixes it. > > > Diffs > ----- > > plasma/tools/plasmapkg/main.cpp 61492fe > > Diff: https://git.reviewboard.kde.org/r/117175/diff/ > > > Testing > ------- > > Compile, add new comic widget, install new comic providers. > > > Thanks, > > Andrei Amuraritei > >
