----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116951/#review55480 -----------------------------------------------------------
kio/kio/kdbusservicestarter.cpp <https://git.reviewboard.kde.org/r/116951/#comment38613> This would hide the error from the debug string, if the caller didn't specify an error pointer. Better use a local var (say localError) and then if (error) *error = localError; - David Faure On March 21, 2014, 3:10 p.m., David Jarvie wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116951/ > ----------------------------------------------------------- > > (Updated March 21, 2014, 3:10 p.m.) > > > Review request for kdelibs. > > > Repository: kdelibs > > > Description > ------- > > When KDBusServiceStarter::findServiceFor() fails to start the requested > service after it is found to not be running, it does not return the error > string. This patch fixes that and makes it behave as in the apidox. > > > Diffs > ----- > > kio/kio/kdbusservicestarter.cpp 90624fb > > Diff: https://git.reviewboard.kde.org/r/116951/diff/ > > > Testing > ------- > > Tested this scenario, and it now returns the error string. > > > Thanks, > > David Jarvie > >
