> On April 25, 2014, 9:44 p.m., Thomas Lübking wrote: > > src/declarativeimports/core/windowthumbnail.cpp, line 231 > > <https://git.reviewboard.kde.org/r/117779/diff/1/?file=268344#file268344line231> > > > > try before this call. > > Alexander Richardson wrote: > Okay, just thought I'd exit early in that case and not bother with the > other stuff. However is this an appropriate fix, or should it be done > somewhere else?
No idea (don't know the code), but that'd apparently be the crash location while the texture might still be generated above - so it has to work here, not before. It would crash because the texture has never been set and just for the function name i'd assume that to be the bug. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117779/#review56577 ----------------------------------------------------------- On April 25, 2014, 9:41 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117779/ > ----------------------------------------------------------- > > (Updated April 25, 2014, 9:41 p.m.) > > > Review request for kde-workspace and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > fix crash when textureNode->texture() is null > > I get this crash very frequently on my system. This is probably only fixing > the symptom and not the underlying issue, however at least plasma no longer > crashes every few minutes > > > Diffs > ----- > > src/declarativeimports/core/windowthumbnail.cpp > 59255f75994adb96b30fb503c759b2e9110ab708 > > Diff: https://git.reviewboard.kde.org/r/117779/diff/ > > > Testing > ------- > > No longer crashes > > > Thanks, > > Alexander Richardson > >
