----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117957/#review58096 -----------------------------------------------------------
kcontrol/fonts/fonts.cpp <https://git.reviewboard.kde.org/r/117957/#comment40398> this seems wrong - the combobox is connected to some wrapper that sets the button state (dunno the code at all) but by the "activated" signal, where it should be the "currentIndexChanged" signal, since it should NOT be called when the user activates even the present entry but certainly should whenever the entry changes for whatever reason (config value re-read, defaults applied, whatever) - Thomas Lübking On May 2, 2014, 7:59 p.m., Andrea Iacovitti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117957/ > ----------------------------------------------------------- > > (Updated May 2, 2014, 7:59 p.m.) > > > Review request for kde-workspace. > > > Bugs: 324728 > http://bugs.kde.org/show_bug.cgi?id=324728 > > > Repository: kde-workspace > > > Description > ------- > > When restoring default configuration: > - Disable "Exclude range checkbox" > - Enable/Disable "Configure..." button accordingly to antialias setting > > > Diffs > ----- > > kcontrol/fonts/fonts.cpp cf21cb1 > > Diff: https://git.reviewboard.kde.org/r/117957/diff/ > > > Testing > ------- > > Tested it compiles and works as expected > > > Thanks, > > Andrea Iacovitti > >
