> On March 28, 2014, 10:59 a.m., Oswald Buddenhagen wrote: > > kdm/backend/client.c, line 1467 > > <https://git.reviewboard.kde.org/r/112294/diff/2/?file=186610#file186610line1467> > > > > this is redundant with the line below. > > if some particular pam module needs this setting, it should be done > > much earlier than here, and the next line would be pointless (we use > > pam_getenvlist). that would also mean that pam is a hard dependency, which > > should be expressed by the configure code and appropriate ifdefs.
Actually, pam_systemd needs it to register the session for the correct seat ... - Stefan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112294/#review54418 ----------------------------------------------------------- On May 18, 2014, 7:44 p.m., Stefan Brüns wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/112294/ > ----------------------------------------------------------- > > (Updated May 18, 2014, 7:44 p.m.) > > > Review request for kde-workspace and Oswald Buddenhagen. > > > Repository: kde-workspace > > > Description > ------- > > This patch implements dynamic multiseat in KDM. It follows the description in: > http://www.freedesktop.org/wiki/Software/systemd/writing-display-managers/ > > In case systemd is no found at compile time, nothing changes. If logind is > not running, nothing changes. If no additional seats have been configured > (some Plugable USB-GPUs are automatically added as additional seats), nothing > changes. > > In case there are additional seats beyond seat0, a reserved display is > promoted to a local static one (and demoted if the seat is removed) and a new > X-Server/greeter is spawned. > > The code has been tested extensively, with a combination of [Radeon dedicated > GPU|Intel iGPU], [Intel iGPU|Displaylink USB GPU] and others. For history of > this patch, see https://bugzilla.redhat.com/show_bug.cgi?id=884271 and > https://bugzilla.redhat.com/show_bug.cgi?id=975079 > > > Diffs > ----- > > kdm/backend/dm.h b2f8c61 > kdm/backend/dm.c 77a2ef7 > kdm/backend/dpylist.c b650c2f > kdm/backend/resource.c 38a8c70 > kdm/config.def 751c0ed > kdm/kfrontend/kdm_config.c 368c8d1 > > Diff: https://git.reviewboard.kde.org/r/112294/diff/ > > > Testing > ------- > > Single seat system, several multiseat systems > > > Thanks, > > Stefan Brüns > >
