----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118313/ -----------------------------------------------------------
Review request for KDE Base Apps, KDE Frameworks and David Faure. Repository: kde-baseapps Description ------- Ported Konqlib from KUrl to QUrl (convert-kurl.pl) Still some ToDos left in the code (I'll mark it inline) Diffs ----- lib/konq/favicons/favicons.h 30f0272 lib/konq/favicons/favicons.cpp 4646fa5 lib/konq/konq_copytomenu.h 0958e20 lib/konq/konq_copytomenu.cpp 7ee5131 lib/konq/konq_copytomenu_p.h eb6649a lib/konq/konq_dndpopupmenuplugin.h 2417080 lib/konq/konq_historyentry.h 6b33b98 lib/konq/konq_historyentry.cpp bfc4a5d lib/konq/konq_historyprovider.h 91b5b87 lib/konq/konq_historyprovider.cpp 10a5e74 lib/konq/konq_nameandurlinputdialog.h 3a943f7 lib/konq/konq_nameandurlinputdialog.cpp 2fb06f9 lib/konq/konq_operations.h b51fa3f lib/konq/konq_operations.cpp 0cbff08 lib/konq/konq_popupmenu.h b5f5e39 lib/konq/konq_popupmenu.cpp caa37e7 lib/konq/konq_popupmenuinformation.h 1454073 lib/konq/konq_popupmenuinformation.cpp 6e1033b lib/konq/konq_sound.h 8063073 lib/konq/konq_sound.cc f8a80a9 lib/konq/konqmimedata.h a2640a2 lib/konq/konqmimedata.cpp 8f9ecf1 lib/konq/tests/favicontest.cpp d48b03d lib/konq/tests/konqmimedatatest.cpp 6a2be4f lib/konq/tests/konqpopupmenutest.cpp 46851c5 Diff: https://git.reviewboard.kde.org/r/118313/diff/ Testing ------- Tests fail konqmimedatatest: (todos) FAIL! : KonqMimeDataTest::testPopulate() 'mimeData->hasUrls()' returned FALSE. FAIL! : KonqMimeDataTest::testCut() 'mimeData->hasUrls()' returned FALSE. konqpopupmenutest: (local setup problem maybe?!) QFATAL : KonqPopupMenuTest::testFile() ASSERT failure in KServiceTypeFactory::KServiceTypeFactory() favicontest: (local setup problem maybe?!) QFATAL : FavIconTest::testSetIconForURL() ASSERT failure in KServiceTypeFactory::KServiceTypeFactory() Thanks, Emmanuel Pescosta