> On May 31, 2014, 9:35 a.m., Oswald Buddenhagen wrote: > > kdm/backend/dm.c, line 1416 > > <https://git.reviewboard.kde.org/r/112294/diff/8/?file=276202#file276202line1416> > > > > that should go into the if for clarity. > > > > more importantly, you also need an unregisterInput() and a > > clearCloseOnFork(). well, for formal correctness at least.
as systemdMonitorDeinit is also called in case of an error I have added both. I also changed the if() to check for systemdMonitorFd >= 0 instead of systemdMonitor. The latter was never set to 0, so in case of too many failed calls to sd_get_seats() systemdMonitorDeinit would be called once, and again during shutdown. A valid systemdMonitorFd implies a valid systemdMonitor. - Stefan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112294/#review58845 ----------------------------------------------------------- On May 29, 2014, 7:03 p.m., Stefan Brüns wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/112294/ > ----------------------------------------------------------- > > (Updated May 29, 2014, 7:03 p.m.) > > > Review request for kde-workspace and Oswald Buddenhagen. > > > Repository: kde-workspace > > > Description > ------- > > This patch implements dynamic multiseat in KDM. It follows the description in: > http://www.freedesktop.org/wiki/Software/systemd/writing-display-managers/ > > In case systemd is no found at compile time, nothing changes. If logind is > not running, nothing changes. If no additional seats have been configured > (some Plugable USB-GPUs are automatically added as additional seats), nothing > changes. > > In case there are additional seats beyond seat0, a reserved display is > promoted to a local static one (and demoted if the seat is removed) and a new > X-Server/greeter is spawned. > > The code has been tested extensively, with a combination of [Radeon dedicated > GPU|Intel iGPU], [Intel iGPU|Displaylink USB GPU] and others. For history of > this patch, see https://bugzilla.redhat.com/show_bug.cgi?id=884271 and > https://bugzilla.redhat.com/show_bug.cgi?id=975079 > > > Diffs > ----- > > cmake/modules/CMakeLists.txt 117b3a5 > kdm/ConfigureChecks.cmake b61fd90 > kdm/backend/CMakeLists.txt 25f383f > kdm/backend/client.c a2d06c2 > kdm/backend/dm.h b2f8c61 > kdm/backend/dm.c 77a2ef7 > kdm/backend/dpylist.c b650c2f > kdm/backend/resource.c 38a8c70 > kdm/backend/server.c d8dd6f3 > kdm/config-kdm.h.cmake 3e8912d > kdm/kfrontend/kdm_config.c 368c8d1 > > Diff: https://git.reviewboard.kde.org/r/112294/diff/ > > > Testing > ------- > > Single seat system, several multiseat systems > > > Thanks, > > Stefan Brüns > >
