> On June 2, 2014, 11:20 a.m., Andrea Iacovitti wrote: > > I think it can go in 4.13 branch, > > there should not be risk of regression.
I don't have submit access so some one will have to do the submit for me. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118407/#review58978 ----------------------------------------------------------- On June 2, 2014, 10:22 a.m., Michael Reeves wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118407/ > ----------------------------------------------------------- > > (Updated June 2, 2014, 10:22 a.m.) > > > Review request for KDE Base Apps. > > > Bugs: 335552 > http://bugs.kde.org/show_bug.cgi?id=335552 > > > Repository: kde-baseapps > > > Description > ------- > > When setting the browser inentifaction via settings the user agent strings > choosen for safari 5 and safari 4 are imposiable. For selecting Safari 5.1 > sends: > "Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10_7_3; en_US) AppleWebKit/537.13+ > (KHTML, like Gecko) Version/5.1.7 Safari/534.57.2 " > Obvoius fake since there is no PPC version of 10.7 in fact there isn't an > i386 version either. Same issue with Safari 4.0 selected. Mozilla/5.0 > (Macintosh; U; PPC Mac OS X 10_6_1; en_US) AppleWebKit/531.21.10 (KHTML, like > Gecko) Version/4.0.4 Safari/531.21.10 > 10.6.1 does not exists for PPC, i386 version does exist. Ditto Safari 6.0. I > haven't found a site that pays atttention but these user agent codes could be > filtered easliy as fakes. > > > Diffs > ----- > > konqueror/settings/kio/uasproviders/safari40.desktop dde6a49 > konqueror/settings/kio/uasproviders/safari517.desktop 34a3a00 > konqueror/settings/kio/uasproviders/safari60.desktop 332a758 > > Diff: https://git.reviewboard.kde.org/r/118407/diff/ > > > Testing > ------- > > none as yet. Just made minor string changes in the .desktop files. Affects > 4.13.x branch as well. > > > Thanks, > > Michael Reeves > >