On 16/06/14 22:46, Albert Astals Cid wrote:
El Dimarts, 27 de maig de 2014, a les 20:06:13, Steve Allewell va escriure:
Greetings
The application KXStitch was recently imported to KDE Playground under
the KDE Incubator process having previously been hosted on Sourceforge.
KXStitch is a cross stitch pattern creator, although it has been used
for other needle work crafts as well. It is a stable and mature
application having been in development for a number of years and has had
several stable releases.
An initial wiki entry has been created.
http://userbase.kde.org/KXStitch
Having fulfilled the incubation criteria, KXStitch has now been moved to
KDE Review with the aim of eventually moving to Extragear/Graphics if
the review is approved.
http://projects.kde.org/projects/kdereview/kxstitch
To cover the requirements for submission:
* A Docbook manual is included in the source. Yuri Chornoivan has been
making some changes to reorganise the manual folder, fix some typos and
some images.
* No libraries are supplied and no apidox is included.
* There are no krazy issues reported at EBN
http://ebn.kde.org/krazy/reports/playground/graphics/kxstitch/index.html
(not sure if this will move with the move to KDE Review)
* No specific usability tests have been done, but KXStitch is being used
by 100's if not 1000's of users (estimated from downloads) with few
problems being reported bug or usability wise.
* There are no obvious performance problems identified at this time.
* KXStitch is completely translatable and a number of translations
already exist. Albert Astals Cid has moved these to i10n.
Please review the KXStitch application and let me know what needs
attention to reach an acceptable position.
Had a look, everything looks good (even i have no clue how to use the app, not
a stitcher myself (tbh i have no idea why paint is disabled and could not find
how to enable it))
The tools are disabled until some floss colours are added to the
palette. I thought it was in the manual tbh but just looked and it isn't
so I will add it in and I think perhaps some additional prompt might be
useful when hovering over the disabled tools.
Some very small stuff (feel free to ignore):
* When opening settings the tabs of Editor, Library and Printer Configuration
do not default to first tab, i think it makes more sense if they do
Probably a simple fix, I'll sort that out.
* Running with valgrind i got
==1172== Conditional jump or move depends on uninitialised value(s)
==1172== at 0x661BD10: QTransform::fromScale(double, double) (in
/usr/lib/x86_64-linux-gnu/libQtGui.so.4.8.6)
==1172== by 0x48E8FC: Palette::paintEvent(QPaintEvent*) (Palette.cpp:284)
==1172== by 0x64C931F: QWidget::event(QEvent*) (in
/usr/lib/x86_64-linux-gnu/libQtGui.so.4.8.6)
==1172== by 0x48E6A9: Palette::event(QEvent*) (Palette.cpp:266)
==1172== by 0x6479E2B: QApplicationPrivate::notify_helper(QObject*, QEvent*)
(in /usr/lib/x86_64-linux-gnu/libQtGui.so.4.8.6)
==1172== by 0x648045C: QApplication::notify(QObject*, QEvent*) (in
/usr/lib/x86_64-linux-gnu/libQtGui.so.4.8.6)
==1172== by 0x50AF428: KApplication::notify(QObject*, QEvent*)
(kapplication.cpp:311)
==1172== by 0x762841C: QCoreApplication::notifyInternal(QObject*, QEvent*)
(in /usr/lib/x86_64-linux-gnu/libQtCore.so.4.8.6)
==1172== by 0x64C3A40: QWidgetPrivate::drawWidget(QPaintDevice*, QRegion const&,
QPoint const&, int, QPainter*, QWidgetBackingStore*) (in
/usr/lib/x86_64-linux-gnu/libQtGui.so.4.8.6)
==1172== by 0x64C446F: QWidgetPrivate::paintSiblingsRecursive(QPaintDevice*,
QList<QObject*> const&, int, QRegion const&, QPoint const&, int, QPainter*,
QWidgetBackingStore*) (in /usr/lib/x86_64-linux-gnu/libQtGui.so.4.8.6)
==1172== by 0x64C35FB: QWidgetPrivate::drawWidget(QPaintDevice*, QRegion const&,
QPoint const&, int, QPainter*, QWidgetBackingStore*) (in
/usr/lib/x86_64-linux-gnu/libQtGui.so.4.8.6)
==1172== by 0x64C446F: QWidgetPrivate::paintSiblingsRecursive(QPaintDevice*,
QList<QObject*> const&, int, QRegion const&, QPoint const&, int, QPainter*,
QWidgetBackingStore*) (in /usr/lib/x86_64-linux-gnu/libQtGui.so.4.8.6)
==1172==
You may want to have a look at Palette.cpp:284
Nothing jumps out as being wrong, I'll dig deeper into it.
P.S: Maybe you can talk to Miritich to provide a default pattern with Konqi?
http://lafabricademiritich.files.wordpress.com/2013/11/konquipattern.pdf
Or I have no clue and this program has nothing to do with about file?
The link is for a knitting pattern, nothing to do with cross stitch :)
although creating a pattern is doable.
Cheers,
Albert
Best Regards
Steve Allewell
Thanks for the feedback
Regards
Steve
