----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118947/#review61020 -----------------------------------------------------------
This review has been submitted with commit 198c1819e382aed93a574c6f9d51c7303985a672 by Wolfgang Bauer to branch master. - Commit Hook On June 26, 2014, 12:03 p.m., Wolfgang Bauer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118947/ > ----------------------------------------------------------- > > (Updated June 26, 2014, 12:03 p.m.) > > > Review request for kdelibs. > > > Bugs: 335556 > http://bugs.kde.org/show_bug.cgi?id=335556 > > > Repository: kdelibs > > > Description > ------- > > The commit > https://projects.kde.org/projects/kde/kdelibs/repository/revisions/48dd1fc50277b861b49613c5f46b6f8b10cc932d > introduced a bug: > It factors out the code to convert a time specification to an actual time > value into the function makeTimeFromList(). > But in that function makeTime(&t, ms, true) is called, whereas the original > code called makeTime(&t, ms, false) for the constructor. > > This patch fixes it by passing the "utc" parameter to makeTime() instead of > "true". > > Please note that this bug is also present in Frameworks5. > > > Diffs > ----- > > kjs/date_object.cpp c8d776c > > Diff: https://git.reviewboard.kde.org/r/118947/diff/ > > > Testing > ------- > > Loaded the test case from the bug report into Konqueror/KHTML. The correct > time is shown now like in other browsers, including Konqueror/WebKit. > > > Thanks, > > Wolfgang Bauer > >
