----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119088/#review61505 -----------------------------------------------------------
May i suggest to replace those new lines with a QScopedPointer (documentation for it: http://qt-project.org/doc/qt-5/qscopedpointer.html) objects? It kinda takes away the need for you to delete since it will simply run out of scope (and be deleted). Or go the C++11 way and use std::unique_ptr: http://en.cppreference.com/w/cpp/memory/unique_ptr - Mark Gaiser On July 2, 2014, 6:02 p.m., Martin Bříza wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119088/ > ----------------------------------------------------------- > > (Updated July 2, 2014, 6:02 p.m.) > > > Review request for kde-workspace. > > > Repository: kde-workspace > > > Description > ------- > > Fixes a memory leak in backlight control with upower. Probably fixes > https://bugs.kde.org/show_bug.cgi?id=271934 . > > > Diffs > ----- > > powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp d38a28f > > Diff: https://git.reviewboard.kde.org/r/119088/diff/ > > > Testing > ------- > > > Thanks, > > Martin Bříza > >
