> On July 12, 2014, 2:11 p.m., Aleix Pol Gonzalez wrote: > > kio/kfile/kfiledialog.cpp, line 316 > > <https://git.reviewboard.kde.org/r/119243/diff/1/?file=289740#file289740line316> > > > > I don't know why you did that, but it doesn't look good. > > Marko Käning wrote: > Actually, when submitting this RR I was also stumbling over this > commented out line and wondered why... > > I am afraid we've to wait for René to figure this out.
If we are going to use Review Board, can we get the kde-mac list added as a group? How do you do that? That would let René, Boudewijn and Nicolas listen in on this stuff, FWIW. - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119243/#review62184 ----------------------------------------------------------- On July 12, 2014, 9:55 a.m., Marko Käning wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119243/ > ----------------------------------------------------------- > > (Updated July 12, 2014, 9:55 a.m.) > > > Review request for kdelibs, Christoph Feck and Ian Wadham. > > > Bugs: 337356 > http://bugs.kde.org/show_bug.cgi?id=337356 > > > Repository: kdelibs > > > Description > ------- > > This bundles both patches submitted by René J.V. Bertin in the associated > issue > > > Diffs > ----- > > kdeui/widgets/kmainwindow.cpp 85beaccdb6f123d2996b8c2b5e38435265c63ff8 > kio/kfile/kfiledialog.h 2b11796897ff095279e7c254a383a9e8e323ea0f > kio/kfile/kfiledialog.cpp 4005ba304a18b59572cc1aece3fcd122ce05fda9 > > Diff: https://git.reviewboard.kde.org/r/119243/diff/ > > > Testing > ------- > > See issue for more info from René. > > --- > > I myself haven't yet tested this. Will report back as soon as I got to it. > > > Thanks, > > Marko Käning > >