> On Juli 15, 2014, 1:15 vorm., David Faure wrote: > > kio/kfile/kurlrequester.cpp, line 277 > > <https://git.reviewboard.kde.org/r/119014/diff/1/?file=285270#file285270line277> > > > > The notion of the "current path" in a GUI program (started graphically) > > makes little sense to me, but I'm not sure what this should be instead .... > > so if this is closer to the earlier behavior, I won't object. > > > > Alternatives would be the home dir or the document path...
Well, I'm just implementing what the api doc says: "The default [...] directory is the current working directory". For graphically started programs the current path usually is $HOME anyway, AFAIK. - Simon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119014/#review62361 ----------------------------------------------------------- On Juni 29, 2014, 5:04 nachm., Simon Bachmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119014/ > ----------------------------------------------------------- > > (Updated Juni 29, 2014, 5:04 nachm.) > > > Review request for kdelibs. > > > Bugs: 92237 > http://bugs.kde.org/show_bug.cgi?id=92237 > > > Repository: kdelibs > > > Description > ------- > > The handling of the start directory in the KUrlRequester is only halfway > implemented. > More in detail: > - m_startDir (the private field holding the start directory) is not > initialised - the default value of startDir() is an empty URL instead of the > current working dir. > - when the start dir changes, it is not always passed to the KUrlCompletion > object of the lineedit. The suggestions showed when entering a relative path > into the LineEdit might be wrong as a consequence. > - when selecting a file, the start directory does not change to the directory > of the selected file - the API doc says it should. > - when the user entered a relative path into the LineEdit, url() returns a > relative path instead of an absolute one. > > This patch should fix these issues. > > > Diffs > ----- > > kio/kfile/kurlrequester.h 2083d4c > kio/kfile/kurlrequester.cpp 661b428 > > Diff: https://git.reviewboard.kde.org/r/119014/diff/ > > > Testing > ------- > > > Thanks, > > Simon Bachmann > >
