> On Juli 21, 2014, 5:16 vorm., Ian Wadham wrote: > > So where are we leaving this? Any conclusions? Any solutions or further > > patches? > > > > Should we report the inconsistent handling of Native file dialogs as a bug > > on bugs.kde.org (without a patch this time)? > > > > If so, against what "product" should we report it (i.e. where a KDE > > developer will be listening)? > > > > I agree with Thomas that "kfiledialog://" should be evaluated before > > deciding whether it is a local file. > > > > I notice also, that in the "condition" that keeps occurring > > ((!startDir.isValid() || startDir.isLocalFile()), the isValid() method > > seems to be inherited from QUrl class and maybe isLocalFile() is too. > > > > It seems odd that a possible condition for invoking QFileDialog methods > > should be that the QUrl is invalid. Perhaps there used to be an isValid() > > in KUrl with a different meaning. > > > > It's all very confusing. Who can sort it out?
dfaure (assined to the kio framework) kfiledialog.cpp would require a general cleanup, but it's in kde4support now, so the predominant question is whether it makes any sense to spend time on this at all. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119243/#review62755 ----------------------------------------------------------- On Juli 14, 2014, 6:15 nachm., Marko Käning wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119243/ > ----------------------------------------------------------- > > (Updated Juli 14, 2014, 6:15 nachm.) > > > Review request for KDE Software on Mac OS X, kdelibs, Christoph Feck, Ian > Wadham, and RJVB Bertin. > > > Bugs: 337356 > http://bugs.kde.org/show_bug.cgi?id=337356 > > > Repository: kdelibs > > > Description > ------- > > This bundles both patches submitted by René J.V. Bertin in the associated > issue > > > Diffs > ----- > > kdeui/widgets/kmainwindow.cpp 85beaccdb6f123d2996b8c2b5e38435265c63ff8 > kio/kfile/kfiledialog.h 2b11796897ff095279e7c254a383a9e8e323ea0f > kio/kfile/kfiledialog.cpp 4005ba304a18b59572cc1aece3fcd122ce05fda9 > > Diff: https://git.reviewboard.kde.org/r/119243/diff/ > > > Testing > ------- > > See issue for more info from René. > > --- > > I myself haven't yet tested this. Will report back as soon as I got to it. > > > Thanks, > > Marko Käning > >