> On 六月 5, 2014, 10:12 a.m., Christoph Feck wrote: > > Please add Plasma developers to the group of reviewers. > > > > Btw, you cannot give "Ship It" to yourself, others have to approve it. > > TOM Harrison wrote: > that just a wrong click :) > > TOM Harrison wrote: > thanks for reminding for the missing reviewers. > > Christoph Feck wrote: > I guess nobody looked at it yet because in the list it appears as > "already approved". I will ping plasma developers.
I am still waiting the plasma reviewer to approve :(, though I am using this path already. - TOM ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review59300 ----------------------------------------------------------- On 六月 5, 2014, 10:32 a.m., TOM Harrison wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118180/ > ----------------------------------------------------------- > > (Updated 六月 5, 2014, 10:32 a.m.) > > > Review request for kde-workspace and Plasma. > > > Bugs: 327580 > http://bugs.kde.org/show_bug.cgi?id=327580 > > > Repository: kde-workspace > > > Description > ------- > > bug patch for slideshow dir list missing > > > Diffs > ----- > > libs/plasmagenericshell/backgrounddialog.cpp 645de3f > > Diff: https://git.reviewboard.kde.org/r/118180/diff/ > > > Testing > ------- > > > Thanks, > > TOM Harrison > >
