----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119594/#review63765 -----------------------------------------------------------
Ship it! This does fix the issue here; +1 from me Also, are you investigating/reporting the bug to Qt devs? - Martin Klapetek On Aug. 4, 2014, 1:57 p.m., Thomas Lübking wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119594/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2014, 1:57 p.m.) > > > Review request for KDE Frameworks, kdelibs, Aleix Pol Gonzalez, Lukáš Tinkl, > and Martin Klapetek. > > > Repository: frameworkintegration > > > Description > ------- > > - saving in the deconstrutor is insufficient, > the dialog might survive the runtime > -> needs to be saved when the dialog is finished or just closed > (the closeEvent is not invoked if at least a sync dialog is finished) > > - ensure a windowHandle and then restore the window size before calling > ::exec() > > - workaround an apparent QWidget QPA bug where even for a created platform > window > the QWindow geometry is not applied on the QWidget > > > Diffs > ----- > > src/platformtheme/kdeplatformfiledialogbase.cpp b823bc7 > src/platformtheme/kdeplatformfiledialogbase_p.h 8ef5b1e > src/platformtheme/kdeplatformfiledialoghelper.h 406a4f1 > src/platformtheme/kdeplatformfiledialoghelper.cpp 520b6f5 > > Diff: https://git.reviewboard.kde.org/r/119594/diff/ > > > Testing > ------- > > See > https://git.reviewboard.kde.org/r/119512/ > > > Thanks, > > Thomas Lübking > >
