----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120182/#review66976 -----------------------------------------------------------
I don't know this code but David's proposed patch differs from the one committed if (m_asMethod || !fileInfo.exists()) { vs if (m_asMethod && !fileInfo.exists()) { .... - Andrea Iacovitti On Set. 19, 2014, 11:25 a.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120182/ > ----------------------------------------------------------- > > (Updated Set. 19, 2014, 11:25 a.m.) > > > Review request for kdelibs and David Faure. > > > Bugs: 336529 > http://bugs.kde.org/show_bug.cgi?id=336529 > > > Repository: kdelibs > > > Description > ------- > > This patch stops KIO::CopyJob from querying for free disk space when the > filesystem type is unknown. > > > Diffs > ----- > > kio/kio/copyjob.cpp 713255b > > Diff: https://git.reviewboard.kde.org/r/120182/diff/ > > > Testing > ------- > > Mounted Andriod filesystem through sshfs and attempted to copy files through > sftp. > > > Thanks, > > Dawit Alemayehu > >