> On Sept. 19, 2014, 10:24 p.m., Martin Gräßlin wrote: > > overall I rather tend to -1 for these changes. I consider changing the > > build system in a long term release as way too risky considering that the > > core development doesn't use this iteration any more. Any unintended > > breakage (e.g. a component also not being built on X11) would probably not > > be spotted and that's something we certainly don't want to do in a minor > > version. > > > > Given that we are already in a late state of the bug fix only development > > it should not be difficult to keep the patch downstream as a > > distro-specific patch.
That's re: the changes to the CMakefile? I frankly don't see the risk. I took care to piggyback most changes to those files on WIN32 conditionals, and there are no APPLEs running Qt/X11 that could run this kde-workspace versin. But checking for false positives on Linux is easy enough (I can try to do that over the weekend). Besides, core development may not be using "this iteration" anymore, but that doesn't mean no one else would spot a hypothetical regression... > On Sept. 19, 2014, 10:24 p.m., Martin Gräßlin wrote: > > kcontrol/krdb/krdb.cpp, lines 544-548 > > <https://git.reviewboard.kde.org/r/120287/diff/1/?file=313477#file313477line544> > > > > this looks like an inintended change No, I often do this when conditionals get too nested to see at a glance if you're in an active/relevant block or not. - René J.V. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120287/#review66990 ----------------------------------------------------------- On Sept. 19, 2014, 10:43 p.m., René J.V. Bertin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120287/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2014, 10:43 p.m.) > > > Review request for KDE Software on Mac OS X and kde-workspace. > > > Repository: kde-workspace > > > Description > ------- > > A few rather straightforward patches to make the relevant bits of KDE4's > kde-workspace build and function on OS X. > The main interest is having the systemsettings control panel to control the > various relevant KDE settings among which desktop search, fonts, colours and > even style. > The oxygen style builds and looks good but shows some updating glitches due > to compositing. > > I'm submitting this patch partly in hope it may be useful in bringing > kf5-workspace to OS X, one day. > > > Diffs > ----- > > CMakeLists.txt 195f99c > kcontrol/CMakeLists.txt fc666b1 > kcontrol/krdb/krdb.cpp 36fc99c > kcontrol/style/CMakeLists.txt d832b20 > libs/CMakeLists.txt c0576fe > > Diff: https://git.reviewboard.kde.org/r/120287/diff/ > > > Testing > ------- > > On OS X 10.6.8 and 10.9.4 with KDE/MacPorts (4.12.5 and more recently kdelibs > git/master, 4.14.1). > > > Thanks, > > René J.V. Bertin > >
