----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120120/#review67317 -----------------------------------------------------------
Ship it! No problem if we want to discuss it longer, and eventually change icon sizes to match text sizes (as is done in Skulpture style) or optionally allow configuring icon sizes. But right now, limiting to a hardcoded 20px value is a bug, that affects usability on HighDPI screens, and should be fixed. Anything else will likely affect several places in KDE code, and could be discussed, but not specific to this bug. - Christoph Feck On Sept. 9, 2014, 8:10 p.m., Boris Egorov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120120/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2014, 8:10 p.m.) > > > Review request for kde-workspace. > > > Bugs: 338883 > https://bugs.kde.org/show_bug.cgi?id=338883 > > > Repository: kmenuedit > > > Description > ------- > > Remove code which restricts app icons to 20x20 pixels > > > Diffs > ----- > > treeview.cpp 99165ca > > Diff: https://git.reviewboard.kde.org/r/120120/diff/ > > > Testing > ------- > > Build app, run it. > > > Thanks, > > Boris Egorov > >
