----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120554/ -----------------------------------------------------------
Review request for kdelibs and Vavelin Kevin. Repository: kompare Description ------- I spent a bit of time porting kompare to kf5. It builds and runs and compares files and folders but I'm pretty sure I missed something. I'll reread my changes also but wanted to get this out there to be played with also. Diffs ----- komparepart/kompareconnectwidget.cpp 2a8cb92 komparepart/komparelistview.cpp b2935c9 komparepart/kompareprefdlg.cpp 0b18696 komparepart/komparesaveoptionswidget.h 9c49815 kompare_shell.cpp 9d22085 komparenavtreepart/CMakeLists.txt da52bc7 komparenavtreepart/komparenavtreepart.h eb08329 komparenavtreepart/komparenavtreepart.cpp d3bdc93 CMakeLists.txt 86e4504 doc/CMakeLists.txt 06d8987 interfaces/CMakeLists.txt 4bb0c6c interfaces/kompareinterface.h a28d209 kompare_shell.h de099ff komparepart/CMakeLists.txt ee83458 komparepart/kompare_part.h 0c4d3dd komparepart/kompare_part.cpp 08df1dc komparepart/kompareconnectwidget.h 03eb746 pics/sc-apps-kompare.svgz PRE-CREATION pics/hi22-app-kompare.png 053b1690571a7b15af10970aff33d39365b9851d pics/hi32-app-kompare.png 1dd3577e8d68a53662b20bb28349bde273a840c8 pics/hi48-app-kompare.png 8eda48e1ada22126a1284b968a4c557d557c949b pics/hisc-app-kompare.svgz 945a66312154ef501013693bd56cf6d454490869 main.cpp ac68e24 pics/128-apps-kompare.png PRE-CREATION pics/16-apps-kompare.png PRE-CREATION pics/22-apps-kompare.png PRE-CREATION pics/32-apps-kompare.png PRE-CREATION pics/48-apps-kompare.png PRE-CREATION pics/CMakeLists.txt 512f6e8 pics/hi128-app-kompare.png ffcd33d50499ac8fb02fe9c5097840f5787f35dd pics/hi16-app-kompare.png c70d54397626bf5d072bb8271076916f43126213 komparepart/komparesaveoptionswidget.cpp 06530d8 komparepart/komparesplitter.h 11a344f komparepart/komparesplitter.cpp 2848f88 komparepart/kompareview.h 93ea064 kompareurldialog.cpp 561dd45 libdialogpages/CMakeLists.txt 2290665 libdialogpages/diffpage.cpp 94221ca libdialogpages/filespage.cpp 417fbd1 libdialogpages/filessettings.h dc3306e libdialogpages/pagebase.h 0cef46f libdialogpages/pagebase.cpp 4aa33d7 libdialogpages/viewpage.cpp e26d728 libdialogpages/viewsettings.h 305e934 Diff: https://git.reviewboard.kde.org/r/120554/diff/ Testing ------- It builds, runs and seems to wok ok comparing files and folders. The QFileDialog it uses wasn't showing files I expected to see though, may need to play with the filters etc. Thanks, Jeremy Whiting