----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120839/#review69293 -----------------------------------------------------------
Aside the minor WS issues, this patch looks correct and *required*. Actually the present code looks extremely weird - the automounting is *only* processed if automounting unknown devices is disabled itfp?? Together w/ the odd manipulation of the "lastSeen" state, ideally someone familiar with the code should make a statement on what was attempted with this apparent nonsense (maybe automounting was broken "intentionally"?) If nobody does (or does veto), you've a +1 from here. solid-device-automounter/kded/DeviceAutomounter.cpp <https://git.reviewboard.kde.org/r/120839/#comment48448> unrelated to this patch, but i'd like to raise: "wtf does the function that apparently performs an automount impact the "lastSeen" state before?" sa->isAccessible() should be false right now, so doesn't this entirely defeat the idea of "lastSeen"? solid-device-automounter/kded/DeviceAutomounter.cpp <https://git.reviewboard.kde.org/r/120839/#comment48447> while at it, you could inject a space between keyword and brace solid-device-automounter/lib/AutomounterSettings.cpp <https://git.reviewboard.kde.org/r/120839/#comment48443> trailing WS solid-device-automounter/lib/AutomounterSettings.cpp <https://git.reviewboard.kde.org/r/120839/#comment48444> trailing WS - Thomas Lübking On Okt. 28, 2014, 11:43 vorm., Frank Schütte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120839/ > ----------------------------------------------------------- > > (Updated Okt. 28, 2014, 11:43 vorm.) > > > Review request for kdelibs, Solid and Christoph Feck. > > > Bugs: 243046 and 261376 > http://bugs.kde.org/show_bug.cgi?id=243046 > http://bugs.kde.org/show_bug.cgi?id=261376 > > > Repository: kde-runtime > > > Description > ------- > > Hi Christoph, > solid-device-automounter fails to automount unknown devices, even if it is > checked, > because in kded/DeviceAutomounter.cpp it fails to evaluate > shouldAutomountDevice. > So this patch corrects the logic to at first evaluate shouldAutomountDevice. > Inside this evaluation automountUnknownDevices is evaluated correctly. > Please review this patch. Christoph Feck urged me to submit this patch. > It took me quite a while to figure it out, though. > Bye, > Frank > > > Diffs > ----- > > solid-device-automounter/kded/DeviceAutomounter.cpp 14b4e87 > solid-device-automounter/lib/AutomounterSettings.cpp 2b3e6be > > Diff: https://git.reviewboard.kde.org/r/120839/diff/ > > > Testing > ------- > > > Thanks, > > Frank Schütte > >