> On nov. 15, 2014, 8:41 a.m., Martin Gräßlin wrote: > > kdeui/tests/kwindowtest.cpp, lines 218-239 > > <https://git.reviewboard.kde.org/r/120931/diff/2/?file=328515#file328515line218> > > > > please note that your test application is fragile as it's based on > > sleep which is dangerous on an async windowing system. > > > > If you want to perform proper tests have a look at the auto-tests in > > KWindowSystem framework. I would be very pleased if it gets an OSX port and > > also the auto-tests adjusted. > > René J.V. Bertin wrote: > Concerning KF5: there is currently only 1 person who could check if these > modifications *compile* and possibly if a well-written test succeeds - Marko. > It is my understanding that improving existing features (like OS X > support) falls in the category of bug fixes according to Albert Astals's > definitions. If this gets committed to an OS X specific branch that's fine > with me too. > > Considering the test: I don't think the test application does async > things and I'm not even sure if it really has an event loop. But you're > right, using sleep is a very quick hack that I ought to have replaced by > something using QTimer or equivalent. Note however that this is an addition > to an existing test case from KWindowSystem; where are the auto-tests that > you mention? > > Martin Gräßlin wrote: > > according to Albert Astals's definitions. > > if Albert acks this change than I'm happy as well. But please note that > I'm highly concerned about the changes getting lost due to increasing > differences between 4.x and 5.x. Personally I would say the changes should go > into frameworks first and be backported to 4.x and not the other way around. > > > I don't think the test application does async things > > yes they do :-) On X11 calls like setCurrentDesktop are async. > > > where are the auto-tests that you mention? > > in frameworks. > > René J.V. Bertin wrote: > > I'm highly concerned about the changes getting lost due to increasing > differences between 4.x and 5.x > > Me too, to be honest. The problem with introducing this kind of changes > into KF5 first is that they cannot be tested (I cannot even compile them). > Given the amount of work remaining to make KF5 accessible (and even appealing > on OS X in my very personal opinion), it really is better to concentrate on > improving KD4-Mac first. There are actually people using it for other things > than just KDE development (including myself) so the testing I mention is not > just on a single dev's machine with his/her usage cases. > I can of course try to port the changes I make to the KF5 equivalent; I > did that with the 1st set of changes I made to KWallet, and it usually isn't > very difficult as (for some unknown reason ;)) the Mac-specific code has > hardly changed in KF5. But as I said, I cannot even compile it (and that's > unlikely to change in the foreseeable future). > > > yes they do :-) On X11 calls like setCurrentDesktop are async. > > Because they go through the DBus? How economic :) > > I'm guessing there's little interest in trying to backport the relevant > auto-test from KF5? > > Thomas Lübking wrote: > No, because X11 is async by design. To ensure sync, one needs to call > XSync(dpy,false) (and xcb_flush as well). > > René J.V. Bertin wrote: > Doh. I knew that of course ...
Since my name has been said: Yes i think that if we have a bugfix, it should go into *all* the releases we support (that includes kdelibs 4.14). As for losing the change for the future, yes that is worrying, there's a few of the Mac changes that the Mac people need to remember to forwardport. - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120931/#review70388 ----------------------------------------------------------- On nov. 14, 2014, 11:04 p.m., René J.V. Bertin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120931/ > ----------------------------------------------------------- > > (Updated nov. 14, 2014, 11:04 p.m.) > > > Review request for KDE Software on Mac OS X and kdelibs. > > > Repository: kdelibs > > > Description > ------- > > This is an attempt to improve the Mac-specific implementation of the > `KWindowSystem` class. > For convenience and future-proofness (and also because I like the language) I > converted `kwindowsystem_mac.cpp` to ObjC++, i.e. `kwindowsystem_mac.mm`, and > added the AppKit framework in the CMakeFile. > > Much of the code in this file is hardly better than gentle hacking, but that > probably concerns the functions that are of least interest on a platform > where KDE doesn't do session management. > > I should probably update the "not yet implemented" debug statements (to > "unsupported"), and I might have another look at kwindowinfo_mac.cpp too. > > > Diffs > ----- > > kdeui/CMakeLists.txt 1454790 > kdeui/tests/kwindowtest.cpp b4012d7 > kdeui/windowmanagement/kwindowsystem_mac.cpp 4200237 > kdeui/windowmanagement/kwindowsystem_mac_p.h PRE-CREATION > kdeui/windowmanagement/kwindowsystem_macobjc.mm PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/120931/diff/ > > > Testing > ------- > > On OS X 10.6.8, mostly with the updated kwindowtest utility (which calls > KWindowSystem functions when clicking the Open button in its toolbar). > Also tested on Mac OS X 10.9.4 rebuilding kdelibs from scratch. > > > Thanks, > > René J.V. Bertin > >
