----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121147/#review70516 -----------------------------------------------------------
Looks good to me. +1 Can you look into doing this in KF5 (ECM) as well? - Aleix Pol Gonzalez On Nov. 17, 2014, 3:20 p.m., Milian Wolff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121147/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2014, 3:20 p.m.) > > > Review request for kdelibs, Alex Merry, Aleix Pol Gonzalez, David Faure, and > Matthias Klumpp. > > > Repository: kdelibs > > > Description > ------- > > This silences the following compile warnings with newer GCC versions: > > warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" > > > Diffs > ----- > > cmake/modules/FindKDE4Internal.cmake > 134d14f11706f5a19a9b5e069119add2ea498dde > > Diff: https://git.reviewboard.kde.org/r/121147/diff/ > > > Testing > ------- > > warnings are gone! and see also: https://ghc.haskell.org/trac/ghc/ticket/9185 > which did the same. > > > Thanks, > > Milian Wolff > >
