----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121831/#review74096 -----------------------------------------------------------
processcore/process.h <https://git.reviewboard.kde.org/r/121831/#comment51460> Requires SOVERSION bump. And: wouldn't it be better to move the now private variables behind a d_ptr? - Gregor Mi On Jan. 12, 2015, 2:30 p.m., Gregor Mi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121831/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2015, 2:30 p.m.) > > > Review request for KDE Base Apps and John Tapsell. > > > Repository: libksysguard > > > Description > ------- > > In process.h there are several public fields. I propose to encapsulate the > private fields with getter methods. I implemented it exemplary for the fields > 'login', 'uid' and 'euid'. > > > (In a separate commit I would add the .reviewboardrc file) > > What is the current policy on using small C++ macros as done in this RR? Use > it (code is more compact and readable) or don't use it (better for debugging)? > > > Diffs > ----- > > processcore/process.h 85a3a13388c44f768040dbc6602ab3211edd5b21 > .reviewboardrc PRE-CREATION > processcore/processes_linux_p.cpp 0cff0e8b407a087dc29f755b12ea3d784ba34e6a > processui/ProcessFilter.cpp ec520593fb67c777d56817f2493d40dc5ade0347 > processui/ProcessModel.cpp 3acf52b92f4a8ca054d88aad1ec6b31f4a31f297 > processui/scripting.h 2445c0ab0d81af3283c0f6e9c5f349a3d70b0de9 > processcore/process.cpp 190f4902fa6f3bae2d8b60dbf1a43be71beb1820 > > Diff: https://git.reviewboard.kde.org/r/121831/diff/ > > > Testing > ------- > > Compiles and runs. Data is still shown. No error. > > > Thanks, > > Gregor Mi > >