----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122249/ -----------------------------------------------------------
(Updated Jan. 25, 2015, 5:47 p.m.) Review request for KDE Base Apps, Martin Gräßlin and John Tapsell. Changes ------- call killWindow via dbus Repository: libksysguard Description ------- Current situation: The "End Process..." button has a tooltip which says "To target a specific window to kill, press Ctrl+Alt+Esc at any time." The keyboard shortcut is hardcoded. RR: Add a drop down menu to the "End Process..." button with one action: i18n("Kill a specific window... (Global shortcut: %1)", killWindowShortcut) Diffs (updated) ----- tests/keyboardshortcututiltest.cpp PRE-CREATION processui/CMakeLists.txt 7f87b85e0201e63d69070a71203bbb34851a79c6 processui/ProcessWidgetUI.ui e50f55cf1813b00d49b1716023df487ffbd536e3 processui/keyboardshortcututil.h PRE-CREATION processui/keyboardshortcututil.cpp PRE-CREATION processui/ksysguardprocesslist.cpp 4dc142e864d8353ceafc3a6735ffa81e48291420 tests/CMakeLists.txt 967b03fae1e460bfb22e1a07ef05cf7b49412546 tests/keyboardshortcututiltest.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122249/diff/ Testing ------- Thanks, Gregor Mi