----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122330/#review75164 -----------------------------------------------------------
Ship it! Ship It! - Milian Wolff On Jan. 31, 2015, 5:48 p.m., Denis Steckelmacher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122330/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2015, 5:48 p.m.) > > > Review request for KDE Frameworks, kdelibs and KDevelop. > > > Repository: kcoreaddons > > > Description > ------- > > The KDevelop QML/JS plugin sometimes needs to parse .qmltypes files (in order > to list the content of installed QML modules, for instance), but KDevelop > requires that files parsed using the QML/JS plugin have the text/x-qml mime > type. > > Because .qmltypes and .qmlproject files are valid QML files (they follow the > standard QML syntax), this patch proposes to add these extensions to the ones > associated with the text/x-qml mime type. > > > Diffs > ----- > > src/mimetypes/kde5.xml cc9f71e > > Diff: https://git.reviewboard.kde.org/r/122330/diff/ > > > Testing > ------- > > Installing kcoreaddons and updating the system MIME database allows KDevelop > to detect that files with the .qmltypes and .qmlproject extensions have to be > parsed using the QML/JS language support plugin. This allows QML files to use > QML modules installed system-wide (and fixes the unit tests of kdev-qmljs). > > > Thanks, > > Denis Steckelmacher > >
