> On Feb. 1, 2015, 2:40 p.m., David Faure wrote: > > thumbnail/thumbnail.cpp, line 384 > > <https://git.reviewboard.kde.org/r/122341/diff/1/?file=345985#file345985line384> > > > > Why this change? It's very wrong. > > > > The first arg is a mimetype, therefore you need KMimeTypeTrader. > > > > It compiles with KServiceTypeTrader by stuffing the mimetype into > > "const QString& serviceType" and by stuffing the servicetype into "const > > QString &constraint"...
So how do you do this in KF5? - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122341/#review75090 ----------------------------------------------------------- On Jan. 31, 2015, 11:07 p.m., David Narváez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122341/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2015, 11:07 p.m.) > > > Review request for kde-workspace, Bhushan Shah and David Faure. > > > Repository: kio-extras > > > Description > ------- > > Only major difference would be the lack of fallback to KFMI. Maybe we could > implement thumbnail features in KFileMetadata? > > > Diffs > ----- > > thumbnail/thumbnail.cpp 39e8de5 > > Diff: https://git.reviewboard.kde.org/r/122341/diff/ > > > Testing > ------- > > Only tested compilation. > > > Thanks, > > David Narváez > >