> On Feb. 9, 2015, 10:01 nachm., Kevin Kofler wrote: > > IMHO, QUrl::fromUserInput(str, QString() QUrl::AssumeLocalFile) would be > > safer. Or do you really think "dolphin nonexistentfile" should look up > > "nonexistentfile" over DNS? > > Thomas Lübking wrote: > +1, notably since http://nonexistenfile won't be very helpful in dolphin, > but will directly open a browser. > One could end up on nasty pages. > > Arjun AK wrote: > >IMHO, QUrl::fromUserInput(str, QString() QUrl::AssumeLocalFile) would be > safer. Or do you really think "dolphin nonexistentfile" should look up > "nonexistentfile" over DNS? > > > [Done](http://commits.kde.org/kde-baseapps/0f91025a752b37ea4b6f2e7c02507bda5863e71f) > > Frank Reininghaus wrote: > QUrl::AssumeLocalFile looks like a good idea! Unfortunately, it seems > that it's only available in Qt 5.4 and later: > > > http://mail.kde.org/pipermail/kde-frameworks-devel/2015-February/022157.html > > http://mail.kde.org/pipermail/kde-frameworks-devel/2015-February/022158.html > > So there should either be an ifdef-version check, or the Qt version > requirement should be bumped to 5.4. I'm not sure if there are any distros > who will still use Qt 5.3 in their next releases - if not, then bumping the > required Qt version is probably easier and less ugly.
Oops, I didn't realize that we're still supporting 5.3. :-( Fedora ships 5.4 as an official update to all supported releases, so we'd be fine with the requirement just getting bumped. Kompare (ported in October 2014) uses this: https://projects.kde.org/projects/kde/kdesdk/kompare/repository/revisions/master/entry/libdialogpages/diffpage.cpp#L45 - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122475/#review75736 ----------------------------------------------------------- On Feb. 9, 2015, 12:48 nachm., Arjun AK wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122475/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2015, 12:48 nachm.) > > > Review request for KDE Base Apps. > > > Bugs: 343906 > http://bugs.kde.org/show_bug.cgi?id=343906 > > > Repository: kde-baseapps > > > Description > ------- > > URLs passed as commandline arguments should be constructed using > `QUrl::fromUserInput()` > > > Diffs > ----- > > dolphin/src/main.cpp 094402f > > Diff: https://git.reviewboard.kde.org/r/122475/diff/ > > > Testing > ------- > > dolphin /tmp > dolphin ftp.debian.org > > > Thanks, > > Arjun AK > >