> On Feb. 13, 2015, 11:39 p.m., Marko Käning wrote: > > I'd vote for keeping it compatible to Qt 5.3, if that's possible.
+1. Depending on 5.4 in applications already is bad enough even though it can sometimes be necessary but I am against it for our base stuff. Especially in this case where there is a workaround. - Inge ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122556/#review76012 ----------------------------------------------------------- On Feb. 13, 2015, 9:06 a.m., Arjun AK wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122556/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2015, 9:06 a.m.) > > > Review request for KDE Base Apps. > > > Repository: kde-baseapps > > > Description > ------- > > `QUrl::fromUserInput(userInput, workingDirectory, UserInputResolutionOptions > options)` seems to be Qt 5.4+. We either need to bump requirement to 5.4 or > do what kompare > [did](https://projects.kde.org/projects/kde/kdesdk/kompare/repository/revisions/master/entry/libdialogpages/diffpage.cpp#L45) > > > Diffs > ----- > > CMakeLists.txt 6df9015 > > Diff: https://git.reviewboard.kde.org/r/122556/diff/ > > > Testing > ------- > > > Thanks, > > Arjun AK > >
