-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122249/
-----------------------------------------------------------
(Updated Feb. 20, 2015, 11:35 p.m.)
Review request for KDE Base Apps, Martin Gräßlin and John Tapsell.
Changes
-------
- Use QProcess::startDetached("xkill"); instead of using the KWin method. This
is not as advanced as the KWin method (e.g. the action can only be aborted with
right-click instead of also Esc) but this way there is no coupling to KWin
- Add a "Don't ask again" message box that warns the user about what will
happen.
Repository: libksysguard
Description
-------
Current situation:
The "End Process..." button has a tooltip which says "To target a specific
window to kill, press Ctrl+Alt+Esc at any time." The keyboard shortcut is
hardcoded.
RR:
Add a drop down menu to the "End Process..." button with one action:
i18n("Kill a specific window... (Global shortcut: %1)", killWindowShortcut)
Diffs (updated)
-----
processui/CMakeLists.txt 7f87b85e0201e63d69070a71203bbb34851a79c6
processui/ProcessWidgetUI.ui e50f55cf1813b00d49b1716023df487ffbd536e3
processui/keyboardshortcututil.h PRE-CREATION
processui/keyboardshortcututil.cpp PRE-CREATION
processui/ksysguardprocesslist.cpp 450ca600b8aed7ca611ec638610b6c524c96080c
tests/CMakeLists.txt 967b03fae1e460bfb22e1a07ef05cf7b49412546
tests/keyboardshortcututiltest.h PRE-CREATION
tests/keyboardshortcututiltest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/122249/diff/
Testing
-------
File Attachments
----------------
New End Process button with drop down arrow
https://git.reviewboard.kde.org/media/uploaded/files/2015/01/28/16301e88-e21b-4358-9a63-a85dae5722bd__screenshot_default1.png
Drop down shows Kill Window
https://git.reviewboard.kde.org/media/uploaded/files/2015/01/28/58df12c5-7350-4bb0-b602-c5716caa9836__screenshot_default2.png
Thanks,
Gregor Mi
