> On Feb. 25, 2015, 5:57 p.m., Mark Gaiser wrote: > > I "think" this is OK, but just don't know. > > > > Anyway, your diff is for kdelibs (KDE SC 4.xx). I don't know if that gets > > another release. Either way, KIO frameworks [1] is where this should be > > applied to when you get a ship it. > > [1] http://quickgit.kde.org/?p=kio.git > > Luigi Toscano wrote: > kdelibs 4.14 still receives fixes and it's released with KDE Applications > (at least as long as we have kdelibs4-based applications). So, if it fixes a > bug, it can go in. > Of course it should be forward-ported to KIO Framework if it is still > relevant there.
So shall I commit this (and https://git.reviewboard.kde.org/r/122653/ as well)? AFAIK next Applications release is due in short time. Will of course forward port to KF5 - Stefan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122652/#review76626 ----------------------------------------------------------- On Feb. 20, 2015, 9:28 p.m., Stefan Brüns wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122652/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2015, 9:28 p.m.) > > > Review request for kdelibs. > > > Bugs: 339193 > http://bugs.kde.org/show_bug.cgi?id=339193 > > > Repository: kdelibs > > > Description > ------- > > The default value for UDSEntry::numberValue(...) is 0, whereas KFileItem > uses the special value KFileItem::Unknown == (mode_t) -1. > > CCBUG: 339193 > > > Diffs > ----- > > kio/kio/kfileitem.cpp f431d3608cfe646fb882365921e694af8ff8838f > > Diff: https://git.reviewboard.kde.org/r/122652/diff/ > > > Testing > ------- > > dolphin remote: > -> no lock icon on smb:, mtp:, ... links > > > Thanks, > > Stefan Brüns > >
