> On mar. 4, 2015, 9:19 p.m., Albert Astals Cid wrote: > > Given the BIC change is already part of 4.14.6 i'd say we just ignore it, > > it's not like anyone cares for that symbol, right? > > Luigi Toscano wrote: > Is it already out? If not, no way to skip 4.14.6 or mark it as "don't use > it" for distributions (or tell them to ship the patches)? > I would vote for that. > (for sure the revert should be introduced in frameworks before 5.8; a > BIC-incompatible version was never released)
Yes https://www.kde.org/announcements/announce-applications-14.12.3.php - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122812/#review77021 ----------------------------------------------------------- On mar. 4, 2015, 5:26 p.m., Andrea Iacovitti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122812/ > ----------------------------------------------------------- > > (Updated mar. 4, 2015, 5:26 p.m.) > > > Review request for kdelibs and Albert Astals Cid. > > > Repository: kdelibs > > > Description > ------- > > First of all sorry for that! > In commit c2046dd7064634d4d6ba50cafd8b1047bd133859 I introduced a BIC by > renaming public DOMString::trimSpaces() to DOMString::parsedUrl(). > However AFICT trimSpaces() was only used internally by khtml. > I can either revert the commit or apply this patch that reinstate old > DOMString::trimSpaces() and mark it as deprecated. > > > Diffs > ----- > > khtml/dom/dom_string.h 087f697 > khtml/dom/dom_string.cpp a3c4abd > > Diff: https://git.reviewboard.kde.org/r/122812/diff/ > > > Testing > ------- > > > Thanks, > > Andrea Iacovitti > >