> On March 29, 2015, 6:34 p.m., Kai Uwe Broulik wrote: > > Thank you for this patch! > > > > However, we chose to remove the percentage from the brightness sliders in > > the battery monitor since you basically change the brightness to your > > liking and not to some odd percentage, so adding them back in the > > PowerDevil settings doesn't make sense. > > Siddhartha Sahu wrote: > Hi Kai, > > Yes for the battery monitor it is not really required because we get > immediate feedback. > > In the KCM, the sliders are for different profiles which come into play > at different times. I do not like the brightness change that happens when I > remove my AC adaptor for example, so I keep the brightness levels the same in > all the profiles. Setting it the same is a tad tedious currently because I > need to swtich tabs multiple times to check if both are in the same position. > > Well, I guess mine is a very special case, and would understand if this > patch does not really make sense in the main repo. I can keep using it as a > special patch on my end :) > > Kai Uwe Broulik wrote: > What speaks against just unchecking the brightness action? Then it won't > change it when you plug in or out the AC. > I hate when it messes with my brightness, so I just turned everything off > and only ever manually change it :) > > Siddhartha Sahu wrote: > Ah. Why did I not think of that. Obvious in hindsight :D > > Discarding the RR then. Thanks! > > Teemu Rytilahti wrote: > This is probably not the proper forum to ask, but the annoying problem of > jumpy brightness would in my opinion better be solved by just saving the > brightness to the active profile when the brightness gets changed. That way > it would at least be consistent even though powerdevil decides that it's time > to change the profile.. Unfortunately it's a design decision to keep it the > way it is, iirc? > > Thomas Lübking wrote: > How's that effectively different from preventing powerdevil to adjust the > brightness itfp?
Ah, sorry, I was thinking about something else there, namely making it easier to adjust the profile brightnesses to be used by the active profile. - Teemu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123169/#review78180 ----------------------------------------------------------- On March 29, 2015, 6:59 p.m., Siddhartha Sahu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123169/ > ----------------------------------------------------------- > > (Updated March 29, 2015, 6:59 p.m.) > > > Review request for kde-workspace. > > > Repository: powerdevil > > > Description > ------- > > I prefer to keep the same brightness level for all profiles. But its a bit > difficult to set the same value in all tabs using just the slider. This patch > adds a percentage value next to the slider. Screenshot included. > > > Diffs > ----- > > daemon/actions/bundled/brightnesscontrolconfig.h 7ba29a7 > daemon/actions/bundled/brightnesscontrolconfig.cpp 3b5aaad > > Diff: https://git.reviewboard.kde.org/r/123169/diff/ > > > Testing > ------- > > Compiles. KCM displays the percentage corresponding to slider value in all > tabs. > > > File Attachments > ---------------- > > Slider with percentage > > https://git.reviewboard.kde.org/media/uploaded/files/2015/03/29/359f2e65-c52c-4e4e-9c8a-c75c3a9a8576__kcm.png > > > Thanks, > > Siddhartha Sahu > >
