> On Sept. 7, 2015, 1:37 a.m., David Faure wrote: > > konq-plugins/CMakeLists.txt, line 21 > > <https://git.reviewboard.kde.org/r/125010/diff/1/?file=399825#file399825line21> > > > > using macro_log_feature would be better
Hmm, did macro_log_feature get replaced by something else? I can't seem to find it actually used in any kf5 based framework or application here somehow. - Jeremy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125010/#review84941 ----------------------------------------------------------- On Aug. 31, 2015, 8:23 p.m., Jeremy Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125010/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2015, 8:23 p.m.) > > > Review request for kdelibs and David Faure. > > > Repository: kde-baseapps > > > Description > ------- > > Ported kttsd plugin to QtSpeech. > > > Diffs > ----- > > konq-plugins/CMakeLists.txt 1d74e91 > konq-plugins/kttsplugin/CMakeLists.txt 2faa7e6 > konq-plugins/kttsplugin/Messages.sh 3c21b1c > konq-plugins/kttsplugin/khtmlkttsd.cpp c361321 > konq-plugins/kttsplugin/khtmlkttsd.desktop cb0a4bd > konq-plugins/kttsplugin/khtmlkttsd.h 99bc848 > konq-plugins/kttsplugin/khtmlkttsd.rc 75a2c49 > konq-plugins/ttsplugin/CMakeLists.txt PRE-CREATION > konq-plugins/ttsplugin/Messages.sh PRE-CREATION > konq-plugins/ttsplugin/khtmltts.cpp PRE-CREATION > konq-plugins/ttsplugin/khtmltts.desktop PRE-CREATION > konq-plugins/ttsplugin/khtmltts.h PRE-CREATION > konq-plugins/ttsplugin/khtmltts.rc PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/125010/diff/ > > > Testing > ------- > > Builds, and works (wow I haven't ran konqueror in ages...) > > > Thanks, > > Jeremy Whiting > >