-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127944/
-----------------------------------------------------------
(Updated June 5, 2016, 2:52 p.m.)
Status
------
This change has been marked as submitted.
Review request for kde-workspace and Plasma.
Changes
-------
Submitted with commit 226401862f2c68f9bd37e95f6fae241b2d41e733 by Jonathan
Marten to branch master.
Bugs: 360666
https://bugs.kde.org/show_bug.cgi?id=360666
Repository: plasma-integration
Description
-------
The referenced bug says that, by default, there is no file overwrite check when
using QFileDialog to save a file. Indeed, on closer investigating it appears
that there is no way to even explictly force an overwrite check when using the
KDE platform theme, because of this code in
plasma-integration/src/platformtheme/kdeplatformfiledialoghelper.cpp:
// overwrite option
if
(options()->testOption(QFileDialogOptions::FileDialogOption::DontConfirmOverwrite))
{
dialog->m_fileWidget->setConfirmOverwrite(false);
}
The default for KFileWidget is already for no overwrite check (as set in
kio/src/filewidgets/kfilewidget.cpp which initialises
KFileWidgetPrivate::confirmOverwrite to false). There is no way to override
this from the calling application through the platform plugin.
Suggest that the default option should be the same as that defined by Qt for
QFileDialog: always perform an ovewrwrite check on saving, unless the caller
has set the QFileDialog::DontConfirmOverwrite option. This is also a sensible
default to have from the user's point of view. This change does that in the
platform theme plugin, for all saving operations.
Diffs
-----
autotests/kfiledialog_unittest.cpp 59915da
src/platformtheme/kdeplatformfiledialoghelper.cpp 139c35d
tests/qfiledialogtest.cpp 1d69ea1
Diff: https://git.reviewboard.kde.org/r/127944/diff/
Testing
-------
Built plasma-intergration with this change, confirmed correct operation of file
dialogues and that confirmation is requested when overwriting an existing file,
unless the QFileDialog::DontConfirmOverwrite option is specified.
Thanks,
Jonathan Marten
