----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128697/ -----------------------------------------------------------
Review request for kdelibs. Repository: kdelibs Description ------- Clearly the author of this regexp, in 2006, thought gcc would never hit version 6 :-) Diffs ----- cmake/modules/FindKDE4Internal.cmake 7d54b9b83b999f6a6e8541f8e8b89e0b2a105703 Diff: https://git.reviewboard.kde.org/r/128697/diff/ Testing ------- Before: kdemacros:/* #undef __KDE_HAVE_GCC_VISIBILITY */ After: kdemacros.h:#define __KDE_HAVE_GCC_VISIBILITY The impact of this was that symbols were no longer exported in shared libs that use the KDE_EXPORT macro, thus breaking linking. Thanks, David Faure
