----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128746/#review99056 -----------------------------------------------------------
Ping? - Elvis Angelaccio On Aug. 24, 2016, 1:58 p.m., Elvis Angelaccio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128746/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2016, 1:58 p.m.) > > > Review request for KDE Base Apps and David Faure. > > > Repository: kde-baseapps > > > Description > ------- > > This patch adapts the code used in dolphin (see > [1](https://quickgit.kde.org/?p=dolphin.git&a=commitdiff&h=d48b73349241a46ad70cac5a5ce3e11f641650af) > and > [2](https://quickgit.kde.org/?p=dolphin.git&a=commitdiff&h=809ba746952c9768de0163153215d95bd233f5c6)) > to load kfileitemaction plugins with json metadata but no .desktop file. > > There are actually a couple of bugs in the dolphin side that I already fixed > here (dolphin returns if KMimeTypeTrader doesn't find anything; dolphin > doesn't check if a json-only plugin is added twice) - I will fix them in > Dolphin with separate patches. > > > Diffs > ----- > > lib/konq/src/konq_popupmenu.cpp 5ceeddb > > Diff: https://git.reviewboard.kde.org/r/128746/diff/ > > > Testing > ------- > > ark's plugins (Extract/Compress menus) now works. They can also be > enabled/disabled in Settings -> Configure Konqueror -> File Management -> > Services (though this is handled by dolphin). > > > Thanks, > > Elvis Angelaccio > >
