----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129423/#review100929 -----------------------------------------------------------
Ship it! Ship It! - Christoph Feck On Nov. 18, 2016, 10:33 a.m., Jonathan Marten wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129423/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2016, 10:33 a.m.) > > > Review request for KDE Base Apps. > > > Repository: keditbookmarks > > > Description > ------- > > These actions are created by QUndoStack in order that it can manage the > action text. However, this means that they do not get the standard KDE > action icon or shortcuts set. This change sets those by reference to the > appropriate KStandardAction. > > > Diffs > ----- > > src/kbookmarkmodel/commandhistory.cpp 53a8931 > > Diff: https://git.reviewboard.kde.org/r/129423/diff/ > > > Testing > ------- > > Built keditbookmarks (split repository master version) with this change, > observed correct appearance and operation of Undo/Redo actions. > > > Thanks, > > Jonathan Marten > >
