----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129518/#review101036 -----------------------------------------------------------
Ship it! Indeed, you are completely right, sorry. I forgot my own code, but at least I did document it (ksycoca.h, ensureCacheValid(), says (implies) no autodetection for mimeapps.list changes -- after all there are only few places which modify it, so no point in slowing down queries). And that docu suggests KBuildSycocaProgressDialog in GUI programs, so this code is right on. - David Faure On Nov. 21, 2016, 12:25 p.m., Jonathan Marten wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129518/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2016, 12:25 p.m.) > > > Review request for KDE Base Apps and David Faure. > > > Repository: konqueror > > > Description > ------- > > This settings was originally commented out in the sources, requiring a port > to Qt5. There was not actually much porting to be done, apart from setting > the correct QStandardPaths location for the mimeapps.list file, but I've also > tidied up and removed a lot of the old cruft and unused code. > > > Diffs > ----- > > settings/konqhtml/generalopts.cpp facec057 > > Diff: https://git.reviewboard.kde.org/r/129518/diff/ > > > Testing > ------- > > Built Konqueror with these changes, checked correct operation of the Settings > - Configure Konqueror - General dialogue and the setting of the preferred > association for the HTML MIME types. > > > Thanks, > > Jonathan Marten > >
